fallintoplace opened a new pull request, #1735: URL: https://github.com/apache/iceberg-go/pull/1735
## Summary V1 manifest lists may omit added and existing row counts. The reader represents those missing values as -1. When a v3 writer promotes such a manifest, treating -1 as zero can assign a first_row_id without reserving the rows that readers will later assign from record_count. This restores the safe behavior: fail with a clear error until the counts are resolved. The Iceberg specification requires first_row_id assignment to account for data files that receive row IDs through inheritance. ## Changes - reject unknown legacy row counts during v3 first_row_id assignment - keep the row ID cursor unchanged when this validation fails - update the regression test to cover the v1 to v3 case ## Testing - go test . -run TestManifests/TestV3ManifestListWriterRejectsInvalidRowIDRanges -count=1 -v - go test ./... -count=1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
