fallintoplace opened a new pull request, #1730: URL: https://github.com/apache/iceberg-go/pull/1730
## What changed `AllManifests` reads snapshot manifest lists concurrently. When one read failed, the worker sent the error on `errch` and the sequencer closed `results` without emitting a value for the missing snapshot. The iterator could select the closed results channel first and return as if iteration completed, leaving the read error buffered. This keeps consuming terminal events after `results` closes, so the read error is surfaced. ## Tests - Added a regression test for closed results plus a buffered error. - `go test ./table -count=1` - `go test -race ./table -run 'Test(YieldAllManifests|AllManifests)' -count=1` Java loads a snapshot manifest list as one operation and propagates the read failure: https://raw.githubusercontent.com/apache/iceberg/main/core/src/main/java/org/apache/iceberg/BaseSnapshot.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
