laskoviymishka commented on PR #1652: URL: https://github.com/apache/iceberg-go/pull/1652#issuecomment-5219801133
> We could also default to some sane amount of retries, wdyt? commit.retry.num-retries still defaults to 0 because it was parked there as a safety stop while blind retries could corrupt state, and the planned flip to 4 never happened after refresh-and-replay landed, so it's now just a stale default rather than a real blocker (open question tracked in #1015). But changing default has some risks: - It's a silent behavior change: commits that used to fail instantly now go through a few backoff cycles first, so hard conflicts surface a bit slower (small with the default 100ms/60s backoff, but non-zero). - The retry path exercises more machinery by default I would do this as separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
