uros-b commented on code in PR #17528: URL: https://github.com/apache/iceberg/pull/17528#discussion_r3735220773
########## api/src/test/java/org/apache/iceberg/util/TestUnicodeUtil.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.util; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import org.junit.jupiter.api.Test; + +class TestUnicodeUtil { + + @Test + void isCharHighSurrogate() { + // the high-surrogate range is 0xD800 - 0xDBFF + assertThat(UnicodeUtil.isCharHighSurrogate('\uD800')).isTrue(); // first high surrogate + assertThat(UnicodeUtil.isCharHighSurrogate('\uDBFF')).isTrue(); // last high surrogate + // low surrogates and regular characters are not high surrogates + assertThat(UnicodeUtil.isCharHighSurrogate('\uDC00')).isFalse(); // first low surrogate + assertThat(UnicodeUtil.isCharHighSurrogate('a')).isFalse(); + } + + @Test + void truncateStringShorterThanLength() { + // no truncation is needed when the length is at least the number of characters + assertThat(UnicodeUtil.truncateString("abc", 5)).isEqualTo("abc"); + assertThat(UnicodeUtil.truncateString("abc", 3)).isEqualTo("abc"); + } + + @Test + void truncateStringByCodePoints() { + assertThat(UnicodeUtil.truncateString("abcde", 3)).isEqualTo("abc"); + // a surrogate pair is a single unicode character and is not split + String withSurrogatePair = "a😀b"; // "a" + emoji + "b" + assertThat(UnicodeUtil.truncateString(withSurrogatePair, 2)).isEqualTo("a😀"); + } + + @Test + void truncateStringRejectsNonPositiveLength() { + assertThatThrownBy(() -> UnicodeUtil.truncateString("abc", 0)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Truncate length should be positive"); + } + + @Test + void truncateStringMin() { + // the minimum is just the truncated prefix + assertThat(UnicodeUtil.truncateStringMin("abcde", 3)).isEqualTo("abc"); Review Comment: Done, thank you! ########## api/src/test/java/org/apache/iceberg/util/TestUnicodeUtil.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.util; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import org.junit.jupiter.api.Test; + +class TestUnicodeUtil { + + @Test + void isCharHighSurrogate() { + // the high-surrogate range is 0xD800 - 0xDBFF + assertThat(UnicodeUtil.isCharHighSurrogate('\uD800')).isTrue(); // first high surrogate + assertThat(UnicodeUtil.isCharHighSurrogate('\uDBFF')).isTrue(); // last high surrogate + // low surrogates and regular characters are not high surrogates + assertThat(UnicodeUtil.isCharHighSurrogate('\uDC00')).isFalse(); // first low surrogate + assertThat(UnicodeUtil.isCharHighSurrogate('a')).isFalse(); + } + + @Test + void truncateStringShorterThanLength() { + // no truncation is needed when the length is at least the number of characters + assertThat(UnicodeUtil.truncateString("abc", 5)).isEqualTo("abc"); + assertThat(UnicodeUtil.truncateString("abc", 3)).isEqualTo("abc"); + } + + @Test + void truncateStringByCodePoints() { + assertThat(UnicodeUtil.truncateString("abcde", 3)).isEqualTo("abc"); + // a surrogate pair is a single unicode character and is not split + String withSurrogatePair = "a😀b"; // "a" + emoji + "b" + assertThat(UnicodeUtil.truncateString(withSurrogatePair, 2)).isEqualTo("a😀"); + } + + @Test + void truncateStringRejectsNonPositiveLength() { + assertThatThrownBy(() -> UnicodeUtil.truncateString("abc", 0)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Truncate length should be positive"); + } + + @Test + void truncateStringMin() { + // the minimum is just the truncated prefix + assertThat(UnicodeUtil.truncateStringMin("abcde", 3)).isEqualTo("abc"); + } + + @Test + void truncateStringMax() { + // the maximum increments the last code point of the truncated prefix + assertThat(UnicodeUtil.truncateStringMax("abcde", 3)).isEqualTo("abd"); Review Comment: Tnx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
