gaborkaszab commented on code in PR #17545:
URL: https://github.com/apache/iceberg/pull/17545#discussion_r3735051544
##########
api/src/main/java/org/apache/iceberg/io/FileIO.java:
##########
@@ -71,13 +72,21 @@ default InputFile newInputFile(ManifestFile manifest) {
return newInputFile(manifest.path(), manifest.length());
}
- default InputFile newInputFile(ManifestListFile manifestList) {
+ default InputFile newInputFile(EncryptableFile file) {
Preconditions.checkArgument(
- manifestList.encryptionKeyID() == null,
- "Cannot decrypt manifest list: %s (use EncryptingFileIO)",
- manifestList.location());
+ file.encryptionKeyID() == null,
+ "Cannot decrypt file: %s (use EncryptingFileIO)",
+ file.location());
// cannot pass length because it is not tracked outside of key metadata
- return newInputFile(manifestList.location());
+ return newInputFile(file.location());
+ }
+
+ /**
+ * @deprecated will be removed in 2.0.0; use {@link
#newInputFile(EncryptableFile)} instead.
+ */
+ @Deprecated
+ default InputFile newInputFile(ManifestListFile manifestList) {
Review Comment:
I dropped `BaseManifestListFile` because that was package private. Now,
there is no implementation in the library that can call this function, still I
don't think we can drop this, because it'd break API for users that happen to
implement their own `ManifestListFile`. Not likely, but technically feasible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
