zeroshade commented on code in PR #1661:
URL: https://github.com/apache/iceberg-go/pull/1661#discussion_r3732159775
##########
schema_test.go:
##########
@@ -570,6 +570,27 @@ func TestUnmarshalSchema(t *testing.T) {
assert.True(t, tableSchemaSimple.Equals(&schema))
}
+func TestUnmarshalSchemaRejectsInvalidTopLevelShape(t *testing.T) {
Review Comment:
Non-blocking: Consider adding a positive legacy-v1 case omitting both
`schema-id` and `identifier-field-ids`, plus `type: null`, non-string type,
scalar/malformed `fields`, an assertion that nil fields marshal as `[]`, and
receiver preservation after a field-decoding failure. Nested struct/list/map
missing-property cases would also pin the follow-up behavior described in the
review body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
