zeroshade commented on code in PR #1658:
URL: https://github.com/apache/iceberg-go/pull/1658#discussion_r3732114123
##########
table/scanner.go:
##########
@@ -267,10 +267,20 @@ func (scan *Scan) Reporter() metrics.Reporter {
}
func (scan *Scan) UseRef(name string) (*Scan, error) {
+ if name == MainBranch {
Review Comment:
This deliberately treats `UseRef("main")` as a clone/no-op even after
another selector. That matches Java, but it is an exception to the exclusivity
rule and is not obvious from the API.
Suggested fix: document the `main` exception on `UseRef` so callers do not
infer that all refs conflict with an existing snapshot selector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
