DerGut opened a new issue, #2972: URL: https://github.com/apache/iceberg-rust/issues/2972
This is derived from a thread in https://github.com/apache/iceberg-rust/pull/2836#discussion_r3684663264 and from @plusplusjiajia's original implementation on https://github.com/apache/iceberg-rust/pull/2838. There's three issues I see with the freshly introduced `iceberg::catalog::session::Credential` type: 1. the naming of `Credential` already exists in the context of credential vending (see [`iceberg_catalog_rest::StorageCredential`](https://github.com/apache/iceberg-rust/blob/f28ae7dca60904a5f135f3b6eecb03b09032b581/crates/catalog/rest/src/types.rs#L240) - but in Java it's plain [`Credential`](https://github.com/apache/iceberg/blob/c9afdc64f41e42d4601fb3aa02ebe8cd785f453a/core/src/main/java/org/apache/iceberg/rest/credentials/Credential.java#L26)). A new `Credential` concept meaning "any sensitive string" conflicts with it 2. use cases exist for a sensitive string type outside of catalog credentials, like FileIO properties (e.g. `s3.session-token`): `iceberg::catalog` is the wrong place to share it 3. The existing (and analogous) [`iceberg::encryption::SensitiveBytes`](https://github.com/apache/iceberg-rust/blob/f28ae7dca60904a5f135f3b6eecb03b09032b581/crates/iceberg/src/encryption/crypto.rs#L46) type is located somewhere completely different, making it non-obvious that both exists and share semantics -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
