JosephLenton commented on code in PR #2930:
URL: https://github.com/apache/iceberg-rust/pull/2930#discussion_r3730801129
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -584,6 +600,10 @@ impl ArrowSchemaVisitor for ArrowSchemaConverter {
// fail. The enclosing field's own id is read by the caller.
Ok(Type::Variant(VariantType))
}
+
+ fn uuid(&mut self, _field: &FieldRef) -> Result<Self::T> {
Review Comment:
> Would it make sense to add the same kind of check variant() has?
Yes, this check should be in the logic and I will add it. 👍
> Given this PR is specifically about making Arrow<->Iceberg UUID conversion
work, is closing the other direction in scope here too?
Yes, I believe it should tag it with the extension too like variant. I'll
take a look at adding that as well.
Cheers!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
