nastra commented on code in PR #17519:
URL: https://github.com/apache/iceberg/pull/17519#discussion_r3726831277
##########
spark/v4.1/build.gradle:
##########
@@ -106,9 +106,16 @@
project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}") {
testImplementation project(path: ':iceberg-core', configuration:
'testArtifacts')
testImplementation project(path: ':iceberg-data', configuration:
'testArtifacts')
testImplementation project(path: ':iceberg-orc', configuration:
'testArtifacts')
- testImplementation (project(path: ':iceberg-open-api', configuration:
'testFixturesRuntimeElements'))
+ testImplementation(project(path: ':iceberg-open-api', configuration:
'testFixturesRuntimeElements')) {
Review Comment:
isn't the issue that the java-test-fixtures plugin adds an implicit
test-fixtures → main-component dependency which shows up in the dependency tree
as iceberg-open-api depending on itself:
```
+--- project :iceberg-open-api
| +--- project :iceberg-open-api (*)
```
Can you try whether this fixes it?
```
// there are no main sources, so drop the implicit test fixtures -> main
component dependency that
// would otherwise put the disabled main JAR on consumers' classpaths
configurations.testFixturesApi.dependencies.removeIf {
it instanceof ProjectDependency && it.path == project.path
}
```
That way we can fix the issue at one place rather than having to fix this
across all Spark versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
