nssalian commented on PR #17520: URL: https://github.com/apache/iceberg/pull/17520#issuecomment-5200165015
Thank for taking a look @Guosmilesmile. Appreciate the pointer to that PR. I dropped the deriveEngineSchema flag so the shared ParquetFormatModel and factory are back to plain setters. The fallback now lives in RecordVariantShreddingAnalyzer and only fires when engineSchema is null, falling back to the Iceberg schema (same thing for Record), which aligns with the engine-specific placement in the PR you mentioned. I put it in the analyzer rather than the factory since that's the one point both the FormatModel and registry-direct write paths share, so neither can hit a null at resolveColumnIndex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
