rahulsmahadev commented on issue #17358:
URL: https://github.com/apache/iceberg/issues/17358#issuecomment-5199355972
This looks fixed by #17360, which merged on 2026-07-30.
`SnapshotUtil.nullableSnapshotIdAsOfTime` now tracks the maximum qualifying
timestamp instead of relying on the iteration order of the snapshot log:
```java
Long snapshotId = null;
long bestTimestamp = Long.MIN_VALUE;
for (HistoryEntry logEntry : table.history()) {
if (logEntry.timestampMillis() <= timestampMillis
&& logEntry.timestampMillis() > bestTimestamp) {
snapshotId = logEntry.snapshotId();
bestTimestamp = logEntry.timestampMillis();
}
}
```
which is the approach suggested here, and
`TestSnapshotUtil#snapshotIdAsOfTimeWithOutOfOrderHistory` covers the
reverse-order case. Can this be closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
