tanmayrauth opened a new pull request, #1655:
URL: https://github.com/apache/iceberg-go/pull/1655
6th PR of the metrics reporting framework. Implements the previously stubbed
catalog metrics endpoint:
- restMetricsReporter POSTs a ReportMetricsRequest to a table's POST
.../tables/{table}/metrics endpoint. The send runs on a background goroutine
detached from the caller's cancellation, and any error is logged and swallowed,
so reporting never blocks or fails the observed scan/commit.
- The REST catalog combines it with the configured reporter when loading a
table, gated on the opt-in rest.metrics-reporting-enabled property and on the
server advertising the endpoint. It is off by default, so existing REST users
see no new /metrics traffic.
Tests use a custom RoundTripper (no network listener) to assert the async
POST, the flattened report-type wire format, nil-report no-op, and that Report
never blocks on a slow server.
Related to #1236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
