ldudas-marx commented on code in PR #17318: URL: https://github.com/apache/iceberg/pull/17318#discussion_r3721205798
########## format/spec.md: ########## @@ -2085,7 +2085,7 @@ Snapshot summary can include metrics fields to track numeric stats of the snapsh | **`total-delete-files`** | Total number of live positional/equality delete files and deletion vectors in the snapshot | | **`added-records`** | Number of records added in the snapshot | | **`deleted-records`** | Number of records deleted in the snapshot | -| **`total-records`** | Total number of records in the snapshot | +| **`total-records`** | Total number of records in data files in the snapshot before applying deletes | Review Comment: I chose this wording to be consistent with [partition statistics'](https://iceberg.apache.org/spec/?h=metadata#partition-statistics-file) `total_record_count` fields description. I prefer your suggested version because of clarity which was my goal. Should I update the description of partition statistics fields (`data_record_count` or`total_record_count`) to be consistent everywhere? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
