badalprasadsingh commented on code in PR #1637:
URL: https://github.com/apache/iceberg-go/pull/1637#discussion_r3720122815
##########
table/transaction.go:
##########
@@ -60,7 +60,7 @@ func (s snapshotUpdate) fastAppend() *snapshotProducer {
// checks.
func (s snapshotUpdate) mergeOverwrite(commitUUID *uuid.UUID, filter
iceberg.BooleanExpression) *snapshotProducer {
op := s.operation
- if s.operation == OpOverwrite && s.txn.meta.currentSnapshot() == nil {
+ if s.operation == OpOverwrite &&
s.txn.meta.currentSnapshotForRef(s.txn.branch) == nil {
Review Comment:
Yes. For now, I am keeping his PR scoped to the snapshot-parent/lineage +
retry fix and handling the read-side planning in a dedicated follow-up.
I'll make the PR description explicit that read-side planning is not yet
branch-aware so nothing reads as end-to-end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
