gabeiglio commented on PR #3751: URL: https://github.com/apache/iceberg-python/pull/3751#issuecomment-5190731158
@kevinjqliu I opened this PR as the previous one was closed for being stale. Here I've hopefully addressed your comments! 1. CredentialsProvider now accepts a refresh_fn (passed in by the catalog) to fetch new credentials when needed. 2. FileIO now caches filesystems by credentials too, so a cache hit can no longer return a filesystem built with expired credentials. 3. CredentialsProvider owns the credential resolution logic, and the longest-prefix-match against storage credentials. 4. CredentialsProvider exposes a per-scheme hook so refresh logic can be implemented individually per scheme (currently only implemented for S3). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
