1991santhu commented on PR #1640: URL: https://github.com/apache/iceberg-go/pull/1640#issuecomment-5186297162
Good catch, you're right. The code floors at `max(d/2, minWait)`, so half the interval is the real floor and `minWait` only takes over when it's bigger than that. As written the comment would have someone expecting the at-cap wait to reach `minWait`, which it can't. Reworded to "floored at half the interval, or at minWait when minWait exceeds half", and said explicitly that the `minWait` half only matters when `minWait` is more than half of `maxWait`. Thanks for checking the bounds in both branches and the rand/v2 concurrency point. Pushed in 4ab50a5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
