raghav-reglobe commented on code in PR #2683:
URL: https://github.com/apache/iceberg-rust/pull/2683#discussion_r3713625224
##########
crates/iceberg/src/spec/manifest_list/manifest_file.rs:
##########
@@ -179,6 +179,18 @@ impl ManifestFile {
///
/// This method will also initialize inherited values of
[`ManifestEntry`](crate::spec::ManifestEntry), such as `sequence_number`.
pub async fn load_manifest(&self, file_io: &FileIO) -> Result<Manifest> {
+ self.load_manifest_with(file_io, None).await
Review Comment:
Good catch — confirmed. `validate_duplicate_files` was still loading
existing manifests through the self-describing path, so the duplicate check on
append hit the same parse error the scan path used to. Pushed a commit routing
it through `load_manifest_with` (table metadata preferred, same as the scan
path), plus a regression test that corrupts a written manifest's `schema` user
metadata in place and asserts `fast_append` with the duplicate check enabled
succeeds.
That was the only remaining production site loading existing manifests — the
other `load_manifest()` callers are tests reading manifests they just wrote. If
your S3 Tables repro still breaks anywhere after this, I'd be interested in the
error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
