kumarpritam863 commented on code in PR #17450:
URL: https://github.com/apache/iceberg/pull/17450#discussion_r3713500505
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -195,6 +193,14 @@ private void commit(boolean partialCommit) {
}
}
+ @VisibleForTesting
+ static boolean isRetryable(RuntimeException exception) {
+ return exception instanceof CommitFailedException
+ || exception instanceof
org.apache.kafka.clients.consumer.CommitFailedException
+ || exception instanceof
org.apache.kafka.common.errors.RebalanceInProgressException
+ || exception instanceof
org.apache.kafka.common.errors.RetriableException;
Review Comment:
Yeah I think CommitFailedException and RebalanceInProgressException should
be fine along with Iceberg's CommitFailedException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
