okumin commented on code in PR #17500:
URL: https://github.com/apache/iceberg/pull/17500#discussion_r3711281303
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -203,6 +204,10 @@ protected boolean supportsEmptyNamespace() {
return false;
}
+ protected boolean supportsVariant() {
+ return false;
Review Comment:
Thanks for adding the feature flag!
As one of those who develop Iceberg REST API, I'd like this to be turned on
by default. I expect RCK not to be backward-compatible because it is a test
suite. If this is false by default, when another Hive committer updates the
Iceberg library, they are unlikely to enable this flag. If this is true by
default, the feature is surely tested, or they will explicitly turn off this
flag. Either result would help downstream maintainers.
It is not a strong opinion, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
