wombatu-kun commented on code in PR #16498:
URL: https://github.com/apache/iceberg/pull/16498#discussion_r3709157864
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -1025,6 +1025,64 @@ public void testCompareToFileList() throws IOException {
assertThat(result4.orphanFilesCount()).as("Action should find
nothing").isEqualTo(0L);
}
+ @TestTemplate
+ public void testCompareToFileListWithSiblingDirectory() throws IOException {
Review Comment:
Correction to my earlier reply: this PR is now narrowed to `spark/v4.1`
only, so the v3.5 and v4.0 copies this thread is anchored to are no longer part
of the diff. The exact-match case you asked for is unchanged and still covered
- see `testCompareToFileListExcludesPathsOutsideLocationScope` in
`spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java`.
The v3.5 and v4.0 copies will return in a separate `Spark: Backport ...` PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
