anoopj commented on code in PR #16936:
URL: https://github.com/apache/iceberg/pull/16936#discussion_r3708569128
##########
core/src/main/java/org/apache/iceberg/TrackedFileAdapters.java:
##########
@@ -425,4 +980,80 @@ private static PartitionSpec resolveSpec(
throw new IllegalArgumentException(
"Cannot find unpartitioned spec in specs: " + specsById.keySet());
}
+
+ // Presents a TrackedFile as its persisted StructLike, shared by the
reusable write-direction
+ // wrappers.
+ private static Object getByPos(TrackedFile file, int pos) {
Review Comment:
The `getByPos()` here mirrors `TrackedFileStruct.getByPos()`. Since both
track TrackedFile.schema() field order, is there a risk they drift when a field
is added?
I don't have great solutions to avoid this duplication though. We probably
don't want `TrackedFile.getByPos` to call into this method with a self pointer
since we want the structs to be self contained without any dependencies on
adapter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
