pvary commented on PR #16871: URL: https://github.com/apache/iceberg/pull/16871#issuecomment-5167277679
This is misleading: > Guard the null vector so the message becomes Unsupported vector: null, matching the null-safe pattern already used by the default branch in the same class (line 178). The code never reaches line 178 when the `primitive` is null. Every method in GenericArrowVectorAccessorFactory expects the referenced column to be present. Maybe we should fix it correctly for cases where the ArrowReader is used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
