PDGGK commented on PR #17492:
URL: https://github.com/apache/iceberg/pull/17492#issuecomment-5166147218
Good catch, thanks — fixed in `85c9952`, the assertion now chains
`.hasMessage("Interrupted in SQL command")`, matching how the rest of this file
asserts (`listNamespaces` at :203, `listViews` at :305).
That was my miss: I ran `spotlessCheck` locally but not `checkstyleTest`, so
the rule never had a chance to fire. I confirmed it does catch it — removing
the `.hasMessage(...)` again reproduces your finding exactly:
```
[ant:checkstyle] [ERROR] .../jdbc/TestJdbcCatalog.java:1335:
assertThatThrownBy must include a message check like .hasMessage(...)
[AssertThatThrownByWithMessageCheck]
```
`:iceberg-core:checkstyleMain`, `:iceberg-core:checkstyleTest` and the test
itself are all green on the new head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
