kinolaev commented on PR #17196: URL: https://github.com/apache/iceberg/pull/17196#issuecomment-5164151210
@AnatolyPopov @RussellSpitzer I'm still hoping to get another review from you and I'm ready to continue working on this PR. Current state: - `AvroSchemaUtil` Iceberg->Avro conversion methods use `local-timestamp-*` and `timestamp-*` with `adjust-to-utc=true` by default. - `AvroSchemaUtil` Avro->Iceberg conversion methods read `timestamp-*` without `adjust-to-utc` as zoned by default. - Data writers support `local-timestamp-*` and expect zoned timestamps for `timestamp-*` without `adjust-to-utc` by default. - Data readers support `local-timestamp-*` and read `timestamp-*` without `adjust-to-utc` as zoned by default. - Data writers and readers can be configured using the `SupportsLocalTimestamp` interface. - The `write.avro.local-timestamp.enabled` table property (documented, `false` by default) is passed to a data writer through `SupportsLocalTimestamp`, so default behavior remains unchanged. - Readers accept the `read.avro.adjust-to-utc.default` table property (undocumented, `false` by default) through `SupportsLocalTimestamp`, but unfortunately no engine currently passes table properties to the readers. Let me know if you would like to see the last piece - wiring table properties to the readers - included in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
