fallintoplace opened a new pull request, #3707: URL: https://github.com/apache/iceberg-python/pull/3707
# Rationale for this change The `snapshots` metadata table declares `operation` as nullable because snapshots without a summary do not have an operation. However, `InspectTable.snapshots()` converted the missing value with `str(None)`, returning the literal string `"None"` instead of a null value. This change passes the operation directly to PyArrow, preserving null semantics and matching Apache Iceberg Java's snapshots metadata table. ## Are these changes tested? Yes. A regression test creates a snapshot without a summary and verifies that `table.inspect.snapshots()` returns a null operation. The following checks pass locally: - `PYTHONPATH=. uv run pytest tests/table/test_inspect.py -q` (5 passed) - `PYTHONPATH=. uv run --extra datafusion --extra pyiceberg-core pytest tests/table -q` (328 passed) - `make lint` ## Are there any user-facing changes? Yes. For snapshots without a summary, `table.inspect.snapshots()` now returns null in the `operation` column instead of the string `"None"`. There are no API changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
