stevenzwu commented on code in PR #17159:
URL: https://github.com/apache/iceberg/pull/17159#discussion_r3590751274
##########
core/src/main/java/org/apache/iceberg/FieldStats.java:
##########
@@ -46,17 +44,20 @@ interface FieldStats<T> extends StructLike {
boolean tightBounds();
/** The total value count, including null and NaN */
- Long valueCount();
+ long valueCount();
/** The total null value count */
- Long nullValueCount();
+ long nullValueCount();
/** The total NaN value count */
- Long nanValueCount();
+ long nanValueCount();
Review Comment:
consolidate the discussion on how to handle no stats scenario. there are two
options
1. nullable boxed type of `Long`
2. primitive `long` + `ValidationException` + `hasXxx`
The existing APIs consistently use option 1, where `null` means "unknown/not
collected," and callers null-check directly. If we decided to go with option 2,
we should include the guardrails of `ValidationException` and `hasXxx`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
