sqd commented on code in PR #16317: URL: https://github.com/apache/iceberg/pull/16317#discussion_r3588040330
########## parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java: ########## @@ -23,6 +23,7 @@ import static org.apache.iceberg.TableProperties.PARQUET_COLUMN_STATS_ENABLED_PREFIX; import static org.apache.iceberg.TableProperties.PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT; import static org.apache.iceberg.TableProperties.PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT; +import static org.apache.iceberg.TableProperties.PARQUET_ROW_GROUP_ROW_LIMIT; Review Comment: It's mostly just identical property plumbing. We will just be testing the framework (PropertyUtil and the fallback) rather than new logic. I can add a test if you feel strongly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
