szlta commented on code in PR #17155:
URL: https://github.com/apache/iceberg/pull/17155#discussion_r3578151112


##########
docs/docs/catalog-properties.md:
##########
@@ -55,6 +55,7 @@ The following properties configure the behavior of the REST 
catalog client.
 | `rest-page-size`                      | null              | The page size to 
use when listing namespaces, tables, or other paginated resources.              
                                                                                
                |
 | `namespace-separator`                 | `%1F`             | The separator 
character used for namespace levels when communicating with the REST server.    
                                                                                
                   |
 | `scan-planning-mode`                  | `CLIENT`          | Controls where 
scan planning is performed. Supported values: `CLIENT` (client-side planning), 
`SERVER` (server-side planning). Can be overridden per-table by the server in 
LoadTableResponse. |
+| `encryption.kms-type`                 | null              | Advertises the 
catalog-selected KMS provider clients should use for encrypted tables. This is 
independent of the table's storage provider and may be used with 
`key-management-credentials` to initialize or configure the KMS client. The 
value is an open enum with initial values `aws`, `gcp`, and `azure`; catalogs 
may return additional values when the catalog and client agree on KMS client 
resolution and credential config. |

Review Comment:
   Agreed, we need that too, I have it included in this PR now. Also added some 
more context how any setting of `encryption.kms-type` would be overridden by 
server's `/config` response when KMS credential vending is turned on.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to