blackmwk commented on code in PR #2799: URL: https://github.com/apache/iceberg-rust/pull/2799#discussion_r3576416863
########## CONTRIBUTING.md: ########## @@ -121,3 +121,12 @@ dependency versions without always upgrading to the latest. ## Code of Conduct We expect all community members to follow our [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). + +## RFC Process + +For significant changes, new features, or substantial changes to public APIs, consider opening an RFC PR first: Review Comment: We need to clarify that this change is iceberg-rust only, and any changes about spec should be discussed in dev list. ########## CONTRIBUTING.md: ########## @@ -121,3 +121,12 @@ dependency versions without always upgrading to the latest. ## Code of Conduct We expect all community members to follow our [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). + +## RFC Process + +For significant changes, new features, or substantial changes to public APIs, consider opening an RFC PR first: + +1. Create a markdown file in [docs/rfcs/](docs/rfcs/) using the next sequential number (e.g., `0003_your_feature.md`). Explain the scope, use case, and proposed design in prose. +2. After the approach is reviewed and accepted, open a follow-up PR with the initial implementation. + Review Comment: We also need to open a tracking issue to track its progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
