yangshangqing95 commented on code in PR #17134:
URL: https://github.com/apache/iceberg/pull/17134#discussion_r3573906321
##########
core/src/main/java/org/apache/iceberg/MetadataTableType.java:
##########
@@ -36,7 +39,14 @@ public enum MetadataTableType {
ALL_FILES,
ALL_MANIFESTS,
ALL_ENTRIES,
- POSITION_DELETES;
+ POSITION_DELETES,
+ METADATA_TABLES;
+
+ private final String lower;
Review Comment:
Thanks for the review. I was treating the lowercase table name as a property
of MetadataTableType, since it is the canonical metadata table name exposed to
users and used during resolution. My goal was to avoid duplicating the
conversion logic and hard-coded suffixes across metadata table code.
However, I see your point that adding state and accessors to the enum may be
broader than necessary for this PR. If you insist I can move the lowercase
conversion into the new metadata_tables implementation and remove tableName() /
tableNames() from MetadataTableType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
