huan233usc commented on code in PR #810: URL: https://github.com/apache/iceberg-cpp/pull/810#discussion_r3567165610
########## src/iceberg/schema_field.cc: ########## Review Comment: Good call — moved it into the float/double branches (gated on the field type id), so other types no longer touch the literal for this check. The literal type already matches the field type at that point, so `std::get` is safe there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
