zeroshade commented on PR #1436: URL: https://github.com/apache/iceberg-go/pull/1436#issuecomment-4952137835
Heads-up while triaging reviews: #1449 also rewrites the Hadoop `PurgeTable` cleanup, and it additionally gates the final `RemoveAll` on the table's `gc.enabled` property — i.e. it addresses the `gc.enabled=false` data-deletion concern raised in the review here, and adds a `gc.enabled=false` preservation test. The two PRs overlap on the same lines, so they can't both merge as-is. Suggest consolidating on #1449 and closing this (or pulling the `gc.enabled` gate into this PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
