zeroshade commented on code in PR #1443:
URL: https://github.com/apache/iceberg-go/pull/1443#discussion_r3566743399
##########
table/orphan_cleanup.go:
##########
@@ -95,6 +96,9 @@ func WithLocation(location string) OrphanCleanupOption {
func WithFilesOlderThan(duration time.Duration) OrphanCleanupOption {
return func(cfg *orphanCleanupConfig) {
cfg.olderThan = duration
+ if duration < 0 && cfg.validationErr == nil {
Review Comment:
This rejection changes existing behavior: the integration suite calls
`WithFilesOlderThan(-1*time.Hour)` in several places (e.g.
`table/orphan_cleanup_integration_test.go:226,273,314,363,403`) to
intentionally consider *all* files (including future timestamps), so those
tests will now fail at option-validation before scanning. A negative-duration
unit test was added, but the integration fixtures using a negative age weren't
updated. Please either update those call sites to a non-negative age (and set
file mtimes accordingly), or keep an explicit "consider all files" affordance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
