huan233usc commented on PR #17149: URL: https://github.com/apache/iceberg/pull/17149#issuecomment-4951921887
Thanks for the review @szehon-ho! Addressed in 3698f8c73: - Synced the `useParquetBatchReads` comment to note geometry/geography are excluded. - Parametrized DELETE/UPDATE/MERGE/nested over `(mode, vectorized)` so the fallback runs with vectorization both on and off. - Extended the nested-delete test to a struct with both a geometry and a geography field, asserting a non-null nested geometry and a null nested geography round-trip. On the DV assertion: kept the SQL form since this test extends `TestBase` (no `validationCatalog`), with the `operation = 'delete'` filter for determinism — replied inline, happy to revisit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
