timothyw553 commented on code in PR #825:
URL: https://github.com/apache/iceberg-cpp/pull/825#discussion_r3565339345
##########
.github/workflows/cpp-linter.yml:
##########
@@ -77,6 +77,7 @@ jobs:
-DCMAKE_C_COMPILER_LAUNCHER=sccache \
-DCMAKE_CXX_COMPILER_LAUNCHER=sccache \
-DICEBERG_BUILD_SQL_CATALOG=ON \
+ -DICEBERG_BUILD_BENCHMARKS=ON \
Review Comment:
this is just so the benchmarks get linted. I previously did not have this
and cpp-linter failed because the benchmark source wasn’t in
compile_commands.json.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
