gmhelmold opened a new issue, #2812:
URL: https://github.com/apache/iceberg-rust/issues/2812

   The `manifests` metadata table writes every manifest's 
added/existing/deleted counts into **both** the `*_data_files_count` and 
`*_delete_files_count` columns, regardless of the manifest's content type — a 
data manifest reports phantom delete-file counts, and a delete manifest reports 
phantom data-file counts.
   
   The reference implementation gates each column by content type 
(`ManifestsTable.java`, `manifestFileToRow`):
   
   ```java
   manifest.content() == ManifestContent.DATA    ? manifest.addedFilesCount() : 
0, // added_data_files_count
   manifest.content() == ManifestContent.DELETES ? manifest.addedFilesCount() : 
0, // added_delete_files_count
   ```
   
   In `crates/iceberg/src/inspect/manifests.rs` the six `append_value` sites 
use the same `ManifestFile` counts unconditionally. Easy to see with a snapshot 
containing one data and one deletes manifest: both rows show identical counts 
in all six columns.
   
   Found while exploring #823. I have a fix with tests ready; PR incoming.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to