sungwy commented on code in PR #17137:
URL: https://github.com/apache/iceberg/pull/17137#discussion_r3561270952
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3930,6 +3937,9 @@ components:
CreateTableRequest:
type: object
+ description:
+ Table creation request. The field IDs in `schema` are assigned by the
client, but because a newly
+ created table has no committed data, a server MAY (re)assign them when
creating the table.
Review Comment:
Thanks for the reviews @wombatu-kun and @rdblue
> Maybe we should have a general statement like this that the service is
allowed to do things like reassignment, but its actions must not alter the
table data.
I agree this is a good idea @rdblue. I think it'll be helpful to encode this
shared invariant first, and then extend any additional operation specific
invariants that build on that to be encoded respectively.
To do so, I did consider encoding it as a shared invariant in `Schema` which
is a common denominator, but landed on it maybe not being the right place.
`Schema` isn't just a request object, it's also in the response, so putting
this request-only expectation there feels a little out of scope.
I'm open to other suggestions, but for now - I've kept these under the
operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
