zeroshade commented on code in PR #1382:
URL: https://github.com/apache/iceberg-go/pull/1382#discussion_r3553758580
##########
table/table.go:
##########
@@ -554,7 +556,7 @@ func (t Table) doCommit(ctx context.Context, updates
[]Update, reqs []Requiremen
deleteOldMetadata(fs, t.metadata, newMeta)
- return New(t.identifier, newMeta, newLoc, t.fsF, t.cat), nil
+ return New(slices.Clone(t.identifier), newMeta, newLoc, t.fsF, t.cat),
nil
Review Comment:
nit: `New()` already clones the identifier on store, so
`slices.Clone(t.identifier)` here is a double-clone on the commit path.
Harmless for 2–3 element identifiers — fine to leave, just noting it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
