tanmayrauth commented on code in PR #1371:
URL: https://github.com/apache/iceberg-go/pull/1371#discussion_r3553697527
##########
literals.go:
##########
@@ -174,6 +174,24 @@ func LiteralFromBytes(typ Type, data []byte) (Literal,
error) {
var v BinaryLiteral
err := v.UnmarshalBinary(data)
+ return v, err
+ case GeometryType, GeographyType:
Review Comment:
Good catch, agreed. I'll add a dedicated geo literal so .Type() reports
Geometry/Geography honestly, and make its ordering paths (Comparator, To) error
instead of silently running bytes.Compare, LE coord bytes have no valid
ordering anyway. I'll also gate the ordering visitors in evaluators.go so a geo
term returns rowsMightMatch rather than routing through the comparator.
Pushing that now with a test. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
