C-Loftus opened a new pull request, #1426:
URL: https://github.com/apache/iceberg-go/pull/1426
Closes #1230
This PR threads through projjson definition metadata by using a `ctx`
variable in accordance to the guidance in #1230 . Note that some of the writer
call stack did not previously take a `ctx` variable. As such, anything public
has an additional new private helper that takes in a `ctx` to resolve it.
I modified `icebergCRSToGeoArrowMetadata` to take in a `ctx` as well so it
can resolve either normal inline crs or projjson.
This ultimately ends up giving us a VisitGeometry API like the following
```go
func (c convertToArrow) VisitGeometry(g iceberg.GeometryType) arrow.Field {
meta, err := icebergCRSToGeoArrowMetadata(c.ctx, g.CRS())
/// rest removed for brevity ....
}
```
Happy to refactor as maintainers see fit. I wasn't entirely sure on a few of
the refactors and whether or not there is a better way to thread the context
through / if it is reasonable to change the public methods for things like
`SchemaToArrowSchema`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
