rdblue commented on code in PR #17035:
URL: https://github.com/apache/iceberg/pull/17035#discussion_r3539334766
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -348,7 +537,36 @@ void testJavaSerializationRoundTrip() throws IOException,
ClassNotFoundException
@Test
void testKryoSerializationRoundTrip() throws IOException {
- TrackedFileStruct file = createFullTrackedFile();
+ TrackingStruct tracking =
+ new TrackingStruct(
+ EntryStatus.ADDED,
+ 42L,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ "s3://bucket/manifest.avro",
+ 3L);
+ TrackedFileStruct file =
+ new TrackedFileStruct(
+ tracking,
+ FileContent.DATA,
+ FORMAT_VERSION_V4,
+ "s3://bucket/data/file.parquet",
+ FileFormat.PARQUET,
+ newPartition(7, "music"),
+ 100L,
+ 1024L,
+ 7,
+ null,
+ 1,
+ DELETION_VECTOR,
+ null,
+ ByteBuffer.wrap(new byte[] {1, 2, 3}),
+ ImmutableList.of(50L),
+ null);
Review Comment:
In general, yes.
The exception is that I think it is okay to use `null` for struct fields, as
long as those structs have their own serializability test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
