WZhuo commented on code in PR #822:
URL: https://github.com/apache/iceberg-cpp/pull/822#discussion_r3536130030
##########
src/iceberg/inheritable_metadata.cc:
##########
@@ -64,6 +64,7 @@ Status BaseInheritableMetadata::Apply(ManifestEntry& entry) {
if (entry.data_file) {
entry.data_file->partition_spec_id = spec_id_;
+ entry.data_file->data_sequence_number = entry.sequence_number;
Review Comment:
`BaseInheritableMetadata::Apply()` only propagates `data_sequence_number` to
the `DataFile`, but the Java equivalent
(`InheritableMetadataFactory.BaseInheritableMetadata.apply()`) sets four fields:
```java
file.setSpecId(specId);
file.setDataSequenceNumber(manifestEntry.dataSequenceNumber());
file.setFileSequenceNumber(manifestEntry.fileSequenceNumber());
file.setManifestLocation(manifestLocation);
```
Suggestion: either add the fields and propagate them now, or leave an
explicit `// TODO: file_sequence_number and manifest_location` comment so the
gap is visible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
