hsiang-c commented on code in PR #2695:
URL: https://github.com/apache/iceberg-rust/pull/2695#discussion_r3532570500
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -862,7 +863,7 @@ pub mod tests {
.file_format(DataFileFormat::Parquet)
.file_size_in_bytes(parquet_file_size)
.record_count(1)
-
.partition(Struct::from_iter([Some(Literal::long(100))]))
+
.partition(Struct::from_iter([Some(Literal::long(1))]))
Review Comment:
Thanks @mbutrovich, good catch. It is actually a bug in my prior commits b/c
I didn't distinguish field ids that are not present in a data file. This is now
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
