rambleraptor commented on code in PR #1283:
URL: https://github.com/apache/iceberg-go/pull/1283#discussion_r3531785360
##########
table/snapshot_producers.go:
##########
@@ -973,6 +1004,10 @@ func (sp *snapshotProducer) commit(ctx context.Context)
(_ []Update, _ []Require
snapshotID := sp.snapshotID
commitUUID := sp.commitUuid
capturedSnapshot := snapshot // copy the value so the closure is
self-contained
+ // Capture the live snapshotProps map. processManifests updates it on
each
+ // retry (a rewrite re-merges the fresh parent), so the rebuilt summary
+ // below can reflect the winning attempt's operation counts.
+ liveProps := sp.snapshotProps
Review Comment:
Cool, added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
