kszucs opened a new pull request, #3609: URL: https://github.com/apache/iceberg-python/pull/3609
# Rationale for this change HuggingFace Hub (`hf://`) storage support already works via `fsspec`'s `HfFileSystem`, but has no way to pin reads to a specific revision (branch/tag/commit) for reproducibility, unlike iceberg-rust's `HF_REVISION`. `HfFileSystem` resolves `revision` per call rather than as a filesystem-wide default, so `hf.revision` is threaded through as a read-time kwarg on `FsspecInputFile`. Writes and deletes intentionally always target the repository's default branch, since a pinned revision can be an immutable tag or commit and isn't a valid write target. ## Are these changes tested? Yes: unit tests covering revision forwarding on reads (`len()`, `.exists()`, `.open()`), confirming writes don't receive the revision kwarg, the no-revision-set default, and non-`hf` schemes being unaffected. ## Are there any user-facing changes? Yes: new `hf.revision` table/catalog property, documented in `configuration.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
