tanmayrauth commented on issue #1393:
URL: https://github.com/apache/iceberg-go/issues/1393#issuecomment-4895130954
@debugmiller Thanks for the detailed diagnosis, it's spot on for the commit
you referenced (a7c4912, May 26), where `foundDeletedCount == 0` was checked
before `len(notDeleted) == 0`, so an all-DELETED manifest got retained instead
of dropped.
This was fixed on main by #1154 ("Avoid carrying empty overwrite
manifests", a286d19, Jun 8), which reorders the two checks so the
`len(notDeleted) == 0` case is caught first and the empty manifest is dropped —
functionally the same as your proposed fix. Current main
(table/snapshot_producers.go:191-198) already has this.
a7c4912 predates that fix, so a rebase onto current main should resolve
the accumulation. Could you confirm you still see it on latest main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
