wombatu-kun commented on PR #16500: URL: https://github.com/apache/iceberg/pull/16500#issuecomment-4893899074
Hi @rdblue, gentle nudge on this one. All five of your comments from May 27 were addressed the next day in `30256ab67`, and each thread has a reply pointing at the fix: - DV validation moved out of `ContentFileUtil` into a public `DVUtil.validateDV`, with the strict `< Integer.MAX_VALUE` bound you flagged - `FileMetadata.Builder.build()` now also rejects `contentSizeInBytes >= Integer.MAX_VALUE` - `TestBaseDeleteLoader` switched to a single Mockito-mock strategy - Em dashes removed across the diff @steveloughran's later nits were handled in `00d778384`, and he approved earlier today. Would you mind taking another pass when you have a moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
