badalprasadsingh commented on PR #1214: URL: https://github.com/apache/iceberg-go/pull/1214#issuecomment-4893171548
Thank you @laskoviymishka & @zeroshade so much for the re-reivew. I have addressed the comments, please do take a look and tell me if anything else is required from my side. Just a quick heads up: `referenced_data_file` is not a v3-only spec. Its _optional_ for v2 spec. Please check [here](https://github.com/apache/iceberg/blob/2d3f5c24e0697b361fe95362d8ee13b915e98048/format/spec.md?plain=1#L737). Thus, keeping it exposed for users to set it for position deletes in v2 spec (file-scoped position delete files). Happy to know if any further fix is required for the same in iceberg-go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
