fallintoplace commented on code in PR #1369:
URL: https://github.com/apache/iceberg-go/pull/1369#discussion_r3523506768
##########
catalog/rest/rest.go:
##########
@@ -466,11 +472,17 @@ func fromProps(props iceberg.Properties, o *options)
error {
case keyRestSigV4Service:
o.sigv4Service = v
case keyAuthUrl:
- u, err := parseAuthURL(v)
+ u, err := url.Parse(v)
+ if err != nil {
+ return fmt.Errorf("invalid %s %q: %w",
keyAuthUrl, v, err)
+ }
+ authURL = u
+ case keyOAuth2ServerURI:
+ u, err := url.Parse(v)
Review Comment:
Do we have better options than url.Parse(v)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
